Convert images to webp and add scripts to keep doing so #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
content related
|
|
👍 All image files/references (if any) are in webp format, in line with our policy. |
|
@flavioazevedo after you probably received a ridiculous amount of notifications from this, it is now good for review. Converting the images to webp will make the webpage a bit faster and smaller, and meet a grant objective. |
flavioazevedo
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
I cannot stress how amazing this is @LukasWallrich ! REALLY, this is freaking awesome! WOW! THANK YOU!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On reflection, it makes little sense to convert to webp on GitHub - there might be exceptions to handle. Instead, this PR converts all jpg/png files to webp (faster and smaller images), adds a script to do such conversions locally when needed, and adds an action that highlights the potential need to convert to webp on PRs that contain pictures - but leaving it up to the contributor / reviewer whether to bother with that at this moment.